develwoutacause’s avatardevelwoutacause’s Twitter Archive—№ 1,462

  1. How do you prefer your code review comments? 1️⃣ Do X - Too strong. 2️⃣ Please do X - Firm, but still a little strong. 3️⃣ Have you tried X? - Bit passive aggressive. 4️⃣ Can we do X? - Gets annoying the 100th time. 5️⃣ What do you think about X? - Gets annoying the 3rd time.
    On twitter.com Twitter logo develwoutacause’s avatar Mood -2 🙁
    1. …in reply to @develwoutacause
      I feel like 99% of code review comments are effectively "I think X might be better, but please push back if you think that's a bad idea or not practical." Should I use a weaker tone to reflect that, or is it just implicit in the code review setting?
      Permalink On twitter.com Twitter logo develwoutacause’s avatar Mood +4 🙂